[Asterisk-code-review] Realtime: Fix some failing realtime tests (testsuite[master])

Mark Michelson asteriskteam at digium.com
Mon Feb 1 12:01:37 CST 2016


Mark Michelson has uploaded a new change for review.

  https://gerrit.asterisk.org/2135

Change subject: Realtime: Fix some failing realtime tests
......................................................................

Realtime: Fix some failing realtime tests

The two basic_calls tests were failing because they specfified a
non-existent "host" option for the "bob" endpoint. Removing this option
should cause the tests to pass.

The two SDP negotiation tests were failing because they specified "True"
and "False" instead of "yes" or "no". This doesn't normally cause a
problem except that our alembic scripts are strict with what values
databases should accept.

Change-Id: I7bbf0f31c8db8d29b13f60c7f70c697dd56191c0
---
M tests/channels/pjsip/basic_calls/incoming/off-nominal/md5/configs/ast1/pjsip.conf
M tests/channels/pjsip/basic_calls/incoming/off-nominal/userpass/configs/ast1/pjsip.conf
M tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/avpf/configs/ast1/pjsip.conf
M tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/avpf-mismatch/configs/ast1/pjsip.conf
4 files changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/35/2135/1

diff --git a/tests/channels/pjsip/basic_calls/incoming/off-nominal/md5/configs/ast1/pjsip.conf b/tests/channels/pjsip/basic_calls/incoming/off-nominal/md5/configs/ast1/pjsip.conf
index 726e0db..542e63b 100644
--- a/tests/channels/pjsip/basic_calls/incoming/off-nominal/md5/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/basic_calls/incoming/off-nominal/md5/configs/ast1/pjsip.conf
@@ -30,7 +30,6 @@
 
 ; bob is the recipient of outbound calls
 [bob](endpoint-template)
-host=127.0.0.1:5062
 ; Place bob-specific options here
 
 [auth-template](!)
diff --git a/tests/channels/pjsip/basic_calls/incoming/off-nominal/userpass/configs/ast1/pjsip.conf b/tests/channels/pjsip/basic_calls/incoming/off-nominal/userpass/configs/ast1/pjsip.conf
index 8b54b5a..160f7e6 100644
--- a/tests/channels/pjsip/basic_calls/incoming/off-nominal/userpass/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/basic_calls/incoming/off-nominal/userpass/configs/ast1/pjsip.conf
@@ -30,7 +30,6 @@
 
 ; bob is the recipient of outbound calls
 [bob](endpoint-template)
-host=127.0.0.1:5062
 ; Place bob-specific options here
 
 [auth-template](!)
diff --git a/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/avpf/configs/ast1/pjsip.conf b/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/avpf/configs/ast1/pjsip.conf
index 3535948..5995cd7 100644
--- a/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/avpf/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/avpf/configs/ast1/pjsip.conf
@@ -10,7 +10,7 @@
 allow=!all,g722,ulaw,alaw
 
 [alice-avp](endpoint-template)
-use_avpf = False
+use_avpf = no
 
 [alice-avpf](endpoint-template)
-use_avpf = True
\ No newline at end of file
+use_avpf = yes
diff --git a/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/avpf-mismatch/configs/ast1/pjsip.conf b/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/avpf-mismatch/configs/ast1/pjsip.conf
index 3535948..5995cd7 100644
--- a/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/avpf-mismatch/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/avpf-mismatch/configs/ast1/pjsip.conf
@@ -10,7 +10,7 @@
 allow=!all,g722,ulaw,alaw
 
 [alice-avp](endpoint-template)
-use_avpf = False
+use_avpf = no
 
 [alice-avpf](endpoint-template)
-use_avpf = True
\ No newline at end of file
+use_avpf = yes

-- 
To view, visit https://gerrit.asterisk.org/2135
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bbf0f31c8db8d29b13f60c7f70c697dd56191c0
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list