[Asterisk-code-review] res rtp asterisk.c: Initialize ourip passed to ast find ouri... (asterisk[master])

Martin Tomec asteriskteam at digium.com
Wed Dec 28 04:55:58 CST 2016


Martin Tomec has posted comments on this change. ( https://gerrit.asterisk.org/4664 )

Change subject: res_rtp_asterisk.c: Initialize ourip passed to ast_find_ourip().
......................................................................


Patch Set 1: Code-Review-1

It should be safe to call ast_find_ourip() with uninitialized first parameter - it is meant as output parameter. The check should be in the function ast_find_ourip(). Caller should not be responsible for initialization of output parameter. Please correct me, if I am wrong...

-- 
To view, visit https://gerrit.asterisk.org/4664
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35507ea1ad7455d2be188f6ccdd4add7bd150e15
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list