[Asterisk-code-review] chan pjsip: Use session for retrieving CHANNEL() information. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4671 )

Change subject: chan_pjsip: Use session for retrieving CHANNEL() information.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/4671/1/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

Line 791: 	channel = ast_channel_tech_pvt(chan);
Should move this to just before first use.  You now have the channel locked there so it cannot change out from under us because of a masquerade.


Line 816: 	func_args.session = ao2_bump(channel->session);
Should check if func_args.session is NULL.


-- 
To view, visit https://gerrit.asterisk.org/4671
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I335e12b89e1820cafdd92b3e7526b8ba649eb7e6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes