[Asterisk-code-review] app queue: Ensure member is removed from pending when hangin... (asterisk[13])

[Martin Tomec]

Martin Tomec has posted comments on this change. ( https://gerrit.asterisk.org/4611 )

Change subject: app_queue: Ensure member is removed from pending when hanging up.
......................................................................


Patch Set 1:

(1 comment)

> (1 comment)
 > 
 > Minor nit.  Otherwise looks fine.

Good point. Thank you!

https://gerrit.asterisk.org/#/c/4611/1/apps/app_queue.c
File apps/app_queue.c:

PS1, Line 4404: 		do_hang(tmp);
              : 		pending_members_remove(tmp->member);
> The pending_members_remove() is redundant here since you are making do_hang
good point. Thank you


-- 
To view, visit https://gerrit.asterisk.org/4611
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae476b5c06481db18ebe0fa594b3e80fdc9a7d54
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes