[Asterisk-code-review] chan sip: Reorder unload module to deal with stuck TCP threads. (asterisk[13])

Corey Farrell asteriskteam at digium.com
Sat Dec 17 10:34:03 CST 2016


Hello Michael Kuron, Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/4640

to look at the new patch set (#2).

Change subject: chan_sip: Reorder unload_module to deal with stuck TCP threads.
......................................................................

chan_sip: Reorder unload_module to deal with stuck TCP threads.

In some situations TCP threads may become frozen.  This creates the
possibility that Asterisk could segfault if they become unfrozen after
chan_sip has been dlclose'd.  This reorders the unload_module process to
allow abort if threads do not exit within 5 seconds.

High level order as follows:
1) Unregister from the core to stop new requests.
2) Signal threads to stop
3) Clear config based tables (but do not free the table itself).
4) Verify that threads have shutdown, cancel unload if not.
5) Clean all remaining resources.

ASTERISK-26586

Change-Id: Ie23692041d838fbd35ece61868f4c640960ff882
---
M channels/chan_sip.c
1 file changed, 28 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/40/4640/2
-- 
To view, visit https://gerrit.asterisk.org/4640
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie23692041d838fbd35ece61868f4c640960ff882
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>



More information about the asterisk-code-review mailing list