[Asterisk-code-review] chan sip: Reorder unload module to deal with stuck TCP threads. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/4615 )

Change subject: chan_sip: Reorder unload_module to deal with stuck TCP threads.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/4615/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 35465: 	clear_sip_domains();
> This needs to be replaced with:
I've decided instead to just move cleanup of sip_read_id, sip_sock and io back to where they started.  I feel this is lower risk.


-- 
To view, visit https://gerrit.asterisk.org/4615
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie23692041d838fbd35ece61868f4c640960ff882
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>
Gerrit-HasComments: Yes