[Asterisk-code-review] Fixes to various issues reported by pyflakes (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4619 )

Change subject: Fixes to various issues reported by pyflakes
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4619/1/rest-api-templates/transform.py
File rest-api-templates/transform.py:

PS1, Line 55:         tempfile.mkstemp()
            :         with tempfile.NamedTemporaryFile() as out:
I think the tmpfile.mkstemp() line should be deleted.  I don't think the temporary file thus created ever gets deleted by the script.

Also the tempfile.NamedTemporaryFile() does the same thing and automatically deletes the temporary file when it gets closed.


-- 
To view, visit https://gerrit.asterisk.org/4619
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia35c5ac61751b927814cf693994c632c412386ea
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes