[Asterisk-code-review] core/pbx: dialplan show - display filename/line# (asterisk[master])

[Jonathan R. Rose]

Jonathan R. Rose has posted comments on this change. ( https://gerrit.asterisk.org/4633 )

Change subject: core/pbx: dialplan show - display filename/line#
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/4633/1/include/asterisk/pbx.h
File include/asterisk/pbx.h:

Line 529: int ast_add_extension2_with_lines(struct ast_context *con, int replace, const char *extension,
> Do you plan to backport this to 13/14?  If not I think it would be better t
The only gripe I can see with changing the arguments is that it could have an impact on people who have their own modules that register extensions. I'm willing to bet the number of people that applies to is remarkably small if not zero.

I'll address these findings on the weekend.


-- 
To view, visit https://gerrit.asterisk.org/4633
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieccc6abccdff34ed5c7da3511fd24972b8f2dd30
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jonathan R. Rose <jonathan.rose at motorolasolutions.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jonathan R. Rose <jonathan.rose at motorolasolutions.com>
Gerrit-HasComments: Yes