[Asterisk-code-review] app queue: new application QueueUpdate (asterisk[master])

snuffy asteriskteam at digium.com
Fri Dec 9 21:57:11 CST 2016


snuffy has posted comments on this change. ( https://gerrit.asterisk.org/4576 )

Change subject: app_queue: new application QueueUpdate
......................................................................


Patch Set 1:

(3 comments)

Minor coding style issues.

https://gerrit.asterisk.org/#/c/4576/1/apps/app_queue.c
File apps/app_queue.c:

Line 10724: //QueueUpdate application
Should have proper doxygen format / explanation


Line 10770: 				if (!strcasecmp(args.status, "ANSWER"))	{
Indented too far by 1 tab?

the brace at end is tab instead of space..


Line 10794:     
excess spaces


-- 
To view, visit https://gerrit.asterisk.org/4576
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0ab64aed934c25b2a25022adcc7c0624224346e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Sebastian Gutierrez <scgm11 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: snuffy <snuffy22 at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list