[Asterisk-code-review] app queue: add new Service Level calculation (asterisk[13])

[snuffy]

snuffy has posted comments on this change. ( https://gerrit.asterisk.org/4325 )

Change subject: app_queue: add new Service Level calculation
......................................................................


Patch Set 4:

(4 comments)

Minor code formatting issues, cannot comment on rest of functionality

https://gerrit.asterisk.org/#/c/4325/4/apps/app_queue.c
File apps/app_queue.c:

Line 1625: 	int callsabandonedinsl;				/*!< Number of queue calls abandoned in servicelevel */
Spaces after first tab


Line 4612: 	if(callabandonedinsl)
Should be enclosed in braces { } for 'if' statement


Line 9289: 			q->callscompleted, q->callsabandoned,sl,sl2,q->servicelevel);
should be space after each 'comma'


https://gerrit.asterisk.org/#/c/4325/4/configs/samples/queues.conf.sample
File configs/samples/queues.conf.sample:

Line 117: ; There are 2 Service Level Performance Calculations SL and SL2 
misc extra space


-- 
To view, visit https://gerrit.asterisk.org/4325
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0970c620460507cd9d45b0d43600779c8915e770
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sebastian Gutierrez <scgm11 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Sebastian Gutierrez <scgm11 at gmail.com>
Gerrit-Reviewer: snuffy <snuffy22 at gmail.com>
Gerrit-HasComments: Yes