[Asterisk-code-review] Serivce enum overrun (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4595 )

Change subject: Serivce enum overrun
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4595/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 1662: 	for (service = AST_CC_CCBS; service < AST_CC_CCNL; ++service) {
The original code is correct.  sip_cc_service_map[] is dimensioned to take an index of 0 to 3.

Your patch essentially breaks working code.


-- 
To view, visit https://gerrit.asterisk.org/4595
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8859f043113a839e2bdd6d631bd48bd896920174
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes