[Asterisk-code-review] res pjsip registrar: AMI Add RegistrationInboundContactStatu... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4569 )

Change subject: res_pjsip_registrar: AMI Add RegistrationInboundContactStatuses command
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Minor nits.

https://gerrit.asterisk.org/#/c/4569/1/CHANGES
File CHANGES:

Line 42:  * 6 existing contact fields have been added to the end of the
s/6/Six/


https://gerrit.asterisk.org/#/c/4569/1/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

Line 2324: int ast_sip_format_contact_ami(void *obj, void *arg, int flags);
Could use some doxygen.  This is an ao2_callback function.


https://gerrit.asterisk.org/#/c/4569/1/res/res_pjsip_registrar.c
File res/res_pjsip_registrar.c:

PS1, Line 52:             </para>
            :             <warning><para>
            : 				This command just dumps all coonfigured AORs with contacts, even if the contact
            : 				is a permanent one.  To really get just inbound registrations, use
            : 				<literal>PJSIPShowRegistrationInboundContactStatuses</literal>.
            :             	</para>
            :             </warning>
            : 		</description>
Mixing tabs and spaces on indent.  Should only use tabs.


Line 836: 			wrapper.contact_id = (char *)(char *)ast_sorcery_object_get_id(contact);
Redundant cast because once may not be enough to do the job.


-- 
To view, visit https://gerrit.asterisk.org/4569
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I326f12c9ecb52bf37ba03f0748749de4da01490a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes