[Asterisk-code-review] res pjsip outbound registration.c: Filter redundant statsd r... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4543 )

Change subject: res_pjsip_outbound_registration.c: Filter redundant statsd reporting.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/4543/2/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

Line 642: 	if (!strcmp(status_old, status_new)) {
> Should we be worried that status_old and client_state->status don't match s
Your comment seems to be confusing public and private status states.

The string comparison is necessary because the old and new private status state can be different but the publicly reported names can be the same.  For example, the private rejected registration state could be temporary or permanent but the reported public state is rejected.


-- 
To view, visit https://gerrit.asterisk.org/4543
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If851c7d514bb530d9226e4941ba97dcf52000646
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes