[Asterisk-code-review] chan sip: Don't unload module while TCP/TLS threads are stil... (asterisk[13])

Michael Kuron asteriskteam at digium.com
Sat Dec 3 03:51:45 CST 2016


Hello Anonymous Coward #1000019, Joshua Colp, Corey Farrell,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/4538

to look at the new patch set (#3).

Change subject: chan_sip: Don't unload module while TCP/TLS threads are still running
......................................................................

chan_sip: Don't unload module while TCP/TLS threads are still running

If not all TCP/TLS threads have terminated by the time the chan_sip module is
dlclose()d, we get segfaults because the threads try to execute code from a
library that is no longer in memory. This patch ensures that the module does
not get closed and that all containers used by the threads remain allocated.

Change-Id: I23a8abf9e8f73b57ff7ada61984b8506aea6cbde
---
M channels/chan_sip.c
1 file changed, 122 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/38/4538/3
-- 
To view, visit https://gerrit.asterisk.org/4538
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23a8abf9e8f73b57ff7ada61984b8506aea6cbde
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list