[Asterisk-code-review] chan sip: Don't unload module while TCP/TLS threads are stil... (asterisk[master])

[Michael Kuron]

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/4536 )

Change subject: chan_sip: Don't unload module while TCP/TLS threads are still running
......................................................................


Patch Set 2:

If at the time the first pthread_kill(..., SIGURG) is sent, a thread has been started, but hasn't executed far enough to get stuck on a blocking call, the signal will have no effect. Therefore, the signal should be sent again after a while, hoping that the thread has progressed far enough to get stuck on a blocking call.

I think we can tighten the delays from 5/10 seconds to much less, say 1/2 seconds, after I removed the SA_RESTART flag in the other patch.

I'm happy to help testing. I can also explain my test procedure in more detail if that helps.

-- 
To view, visit https://gerrit.asterisk.org/4536
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23a8abf9e8f73b57ff7ada61984b8506aea6cbde
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>
Gerrit-HasComments: No