[Asterisk-code-review] media: Add experimental support for RTCP feedback. (asterisk[14])

[Lorenzo Miniero]

Lorenzo Miniero has posted comments on this change. ( https://gerrit.asterisk.org/4521 )

Change subject: media: Add experimental support for RTCP feedback.
......................................................................


Patch Set 3:

> > (8 comments)
 > >
 > > > (9 comments)
 > >
 > > Just addressed all comments (sorry if this took a while). How
 > > should I push the changes after I make them in order to avoid the
 > > mess I caused a couple of days ago? Will a
 > >
 > > git review -d 4521
 > >
 > > ensure I don't cause trouble? Thanks.
 > 
 > Yeah, 'git review -d 4521' will download the current review into a
 > new branch called 'review/lorenzo_miniero/ASTERISK-26584' and
 > switch to that branch for you.  If you do a 'git log' you'll see
 > that your original commit is the "HEAD".  Make all your changes,
 > then do a 'git commit -a --amend'.  That should bring up your
 > editor with the original commit message.  If you need to change the
 > message do that now but don't change the Change-Id.  If you don't
 > need to make changes to the message just save and the commit will
 > apply.  Once the commit is applied, do 'git review 14' and it will
 > upload the amended commit as a new patchset in teh current review.

Hopefully I just managed to do that :-)

-- 
To view, visit https://gerrit.asterisk.org/4521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd6aa77fb4a7ff546c6025900fc2baf332c31857
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Lorenzo Miniero <lminiero at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Lorenzo Miniero <lminiero at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No