[Asterisk-code-review] Binaural synthesis (confbridge): Adds binaural synthesis to ... (asterisk[master])

[Dennis Guse]

Dennis Guse has posted comments on this change. ( https://gerrit.asterisk.org/3524 )

Change subject: Binaural synthesis (confbridge): Adds binaural synthesis to bridge_softmix.
......................................................................


Patch Set 16: Code-Review-1

(2 comments)

Lock not yet changed.
Will be done on the 9th of December.

https://gerrit.asterisk.org/#/c/3524/13/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

PS13, Line 57: 	/*! The number of channels above the internal sample rate */
             : 	unsigned int num_above_internal_rate;
             : 	/*! The number of channels at the internal sample rate */
             : 	unsigned int num_at_internal_rate;
             : 	/*! The absolute highest sample rate preferred by any channel in the bridge */
             : 	unsigned int highest_supported_rate;
             : 	/*! Is the sample rate locked by the bridge, if so what is that rate.*/
             : 	unsigned int locked_rate;
             : };
             : 
             : struct softmix_translate_helper_entry {
             : 	int num_times_requested; /*!< Once this entry is no longer requested, free the trans_pvt
             : 	and re-init if it was usable. */
> Guidelines: Use tabs to indent not spaces.
Done


PS13, Line 1062: #endif
               : 			{
               : 				sc->write_frame.datalen = softmix_datalen;
               : 				sc->write_frame.samples = softmix_samples;
               : 				memcpy(sc->final_buf, buf, softmix_datalen);
               : 			}
               : 			/* process the softmix channel's new write audio */
               : 			softmix_process_write_audio(&trans_helper, ast_channel_rawwriteformat(bridge_channel->chan), sc, softmix_data->default_sample_size);
               : 
               : 			ast_mutex_unlock(&sc->lock);
               : 
> This conditional code can be simplified:
Done


-- 
To view, visit https://gerrit.asterisk.org/3524
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecdb381b6adc17c961049658678f6219adae1ddf
Gerrit-PatchSet: 16
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Dennis Guse <dennis.guse at alumni.tu-berlin.de>
Gerrit-Reviewer: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes