[Asterisk-code-review] build: Add download capability for external packages (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: build: Add download capability for external packages
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/3769/1//COMMIT_MSG
Commit Message:

PS1, Line 21: Also
            : because codec_g729a is actually in a directory named codec_g729 on the
            : download server
> This should use full URL's so it can be also used for modules not provided 
can't change download_dir since all the codecs and dpma already have it in their manifests.  I CAN add download_url though and have the script check for it in the xml and use it if it's there.


https://gerrit.asterisk.org/#/c/3769/1/codecs/Makefile
File codecs/Makefile:

PS1, Line 99: ifneq ($(XMLSTARLET),:)
            : EXTERNAL_MODS := $(shell $(XMLSTARLET) sel -t -v "/category/member[support_level = 'external']/@name" .moduleinfo)
            : 
            : install::
            : 	$(foreach MODULE,$(filter-out $(MENUSELECT_CODECS),$(EXTERNAL_MODS)),$(ASTTOPDIR)/build_tools/download_externals $(MODULE) || exit 1;)
            : endif
> Can we move this to Makefile.moddir_rules?  I realize it will need tweaks t
yeah i thought of that 2 minutes after i committed but had to run out.  next version will have that moved.


-- 
To view, visit https://gerrit.asterisk.org/3769
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3dcf1289ffd3cb0bbd7dfab3cafbb87be60323a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes