[Asterisk-code-review] named locks: Use ao2 weakproxy to deal with cleanup from con... (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: named_locks: Use ao2_weakproxy to deal with cleanup from container.
......................................................................


Patch Set 1:

(1 comment)

How much do you think we save on the locking vs the addition of the extra object and management?

https://gerrit.asterisk.org/#/c/3747/1/include/asterisk/named_locks.h
File include/asterisk/named_locks.h:

Line 93: #define ast_named_lock_put(lock) ao2_cleanup(lock)
My concern here is if we wanted to backport this patch, it'd break ABI.  Maybe keep __ast_named_lock_put and just have it wrap ao2_cleanup.  Also, a deprecated tag would be good.


-- 
To view, visit https://gerrit.asterisk.org/3747
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I644e39c6d83a153d71b3fae77ec05599d725e7e6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes