[Asterisk-code-review] res pjsip: qualify/unqualify added/deleted realtime endpoints (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip: qualify/unqualify added/deleted realtime endpoints
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Just add the comments and cherry-pick.  Otherwise OK.

https://gerrit.asterisk.org/#/c/3732/1/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 175: 
Could you just add some comments here to describe that you're using FULLY_BOOTED to filter out contacts that already existed when asterisk started and expiration_time to select only permanent contacts.


-- 
To view, visit https://gerrit.asterisk.org/3732
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93dded9121edb113076903d1aa95402f799f8fe
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes