[Asterisk-code-review] ao2 container: Add support for transparent storage of weakpr... (asterisk[master])

Corey Farrell asteriskteam at digium.com
Sun Aug 28 14:52:08 CDT 2016


Hello Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/3749

to look at the new patch set (#2).

Change subject: ao2_container: Add support for transparent storage of weakproxy objects.
......................................................................

ao2_container: Add support for transparent storage of weakproxy objects.

This adds support for declaring that a container will hold weakproxy
objects.  This causes returns from ao2_find and ao2_callback to lookup
the real object held by the weakproxy.

I do not believe this is ready to merged, but I'm ready to ask if it's
worth pursuing.  Testing was done with some of the PJSIP registrar tests
due to their use of named locks.  Many of these tests use SIGKILL to
stop Asterisk, but this was the case before my patch.  I have not found
any test where this change causes Asterisk shutdown to timeout.

Change-Id: I48f2dfb85e97fd0a382a869cd084afda129c95d9
---
M include/asterisk/astobj2.h
M main/astobj2_container.c
M main/named_locks.c
3 files changed, 67 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/49/3749/2
-- 
To view, visit https://gerrit.asterisk.org/3749
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I48f2dfb85e97fd0a382a869cd084afda129c95d9
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019



More information about the asterisk-code-review mailing list