[Asterisk-code-review] res pjsip: qualify/unqualify added/deleted realtime endpoints (asterisk[13])

George Joseph asteriskteam at digium.com
Fri Aug 26 13:35:35 CDT 2016


George Joseph has posted comments on this change.

Change subject: res_pjsip: qualify/unqualify added/deleted realtime endpoints
......................................................................


Patch Set 1:

(1 comment)

I want to test this a bit before +1'ing.

https://gerrit.asterisk.org/#/c/3732/1/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 417: 			contact_deleted(contact);
> Is this the correct fix for this? There is an observer on the contact sorce
Deleting an object from the database doesn't trigger any observers unless you reload.


-- 
To view, visit https://gerrit.asterisk.org/3732
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93dded9121edb113076903d1aa95402f799f8fe
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list