[Asterisk-code-review] channel: Hang-up crashed Asterisk while freeing private data. (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: channel: Hang-up crashed Asterisk while freeing private data.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3731/1/main/channel.c
File main/channel.c:

PS1, Line 2352: 		ast_log_callid(LOG_WARNING, callid, "Channel '%s' may not have been hung up" \
              : 			" properly; leaking memory. Please report via http://issues.asterisk.org." \
              : 			" If feasible, please include" \
              : 			" http://wiki.asterisk.org/wiki/display/AST/Getting+a+Backtrace" \
              : 			" via an interactive session in the GNU Debugger (gdb).\n",
              : 			ast_channel_name(chan));
This is really long winded.  How about:
"BUG! Channel '%s' may not have been hung up properly and memory may have been leaked.\n"

It would also not be amiss to stick an ast_assert(0) after the message is logged.


-- 
To view, visit https://gerrit.asterisk.org/3731
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id085417d7e0a5c61382582e7d250b56ab3c00a1b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes