[Asterisk-code-review] RFC: ao2 reference storage location logging. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: RFC: ao2 reference storage location logging.
......................................................................


Patch Set 5:

> It might be better to make refcounter.py able to process multi
 > gigabyte files without choking.  One way would be to preprocess the
 > ref log file by sorting the lines into temporary files that are
 > then processed separately.  i.e., break the job into smaller
 > pieces.

I've added an optional preprocess stage that can be used against very large files.  The preprocess performs minimum scan to identify objects that leak, then the main processing skips the non-leaking objects.  On my own system processing a 9GB file took a bit more than an hour without preprocess, or about 10 minutes with preprocess.  The memory usage with preprocess was also significantly less than without preprocess.

My first attempt was to have refcounter.py pipe the input file to the 'sort' utility, but this actually caused it to fail on my system due to /tmp being tmpfs (4GB).

-- 
To view, visit https://gerrit.asterisk.org/3141
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0a51cefaa98c83eab18aa2b7d18850bb33951
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No