[Asterisk-code-review] issue ASTERISK-26282 (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: issue ASTERISK-26282
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

You've made substantial formatting changes to this code, some of which have resulted in stuff being indented that shouldn't. It's best to have these kind of changes as a separate commit away from any bug fixes.

https://gerrit.asterisk.org/#/c/3578/1//COMMIT_MSG
Commit Message:

Line 7: issue ASTERISK-26282
Please follow the page on the wiki[1] for constructing your commit message.

[1] https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/#/c/3578/1/apps/app_macro.c
File apps/app_macro.c:

PS1, Line 155: 	 static char *app = "Macro";
             : 	 static char *if_app = "MacroIf";
             : 	 static char *exclusive_app = "MacroExclusive";
             : 	 static char *exit_app = "MacroExit";
             : 
             : 	 static void macro_fixup(void *data, struct ast_channel *old_chan,
             : 							 struct ast_channel *new_chan);
             : 
             : 	 static const struct ast_datastore_info macro_ds_info = {
             : 		 .type = "MACRO",
             : 		 .chan_fixup = macro_fixup,
             : 	 };
These should not be indented like this.


Line 249: 	char *my_macro_exten = NULL;
This can be a const char.


PS1, Line 341: 	/*
             : 	   if (!ast_exists_extension(chan, fullmacro, "s", 1,
             : 	   S_COR(ast_channel_caller(chan)->id.number.valid, ast_channel_caller(chan)->id.number.str, NULL))) {
             : 	   if (!ast_context_find(fullmacro)) 
             : 	   ast_log(LOG_WARNING, "No such context '%s' for macro '%s'. Was called by %s@%s\n", fullmacro, macro, ast_channel_exten(chan), ast_channel_context(chan));
             : 	   else
             : 	   ast_log(LOG_WARNING, "Context '%s' for macro '%s' lacks 's' extension, priority 1\n", fullmacro, macro);
             : 	   return 0;
             : 	   }
             : 	 */
This should be removed since it's the old code.


-- 
To view, visit https://gerrit.asterisk.org/3578
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I939aa2a694148cc1054dd75ec0c47c47f47c90fb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: chris de rock <chris at derock.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes