[Asterisk-code-review] rtp engine: Allow more than 32 dynamic payload types. (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: rtp_engine: Allow more than 32 dynamic payload types.
......................................................................


Patch Set 1:

I am not sure I understand your concern, yet.

This code should not be visited by any Asterisk modules, yet. However, my GSM-EFR, AMR, AMR-WB, and upcoming EVS modules are affected in Asterisk 14 already.

This change uses unassigned types, which should not be an issue for any implementation – only in the very last resort five already assigned types are reassigned. If you like, I can add a LOG_NOTICE that this part of the source-code was entered, and list the formats/codecs which got reassigned. Furthermore, I can give an explanation how to circumvent that behavior (through disallowing SILK, Codec 2, or renaming code modules to change load order).

-- 
To view, visit https://gerrit.asterisk.org/3681
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc96ab764bc30098a178b841cbf7146f9d64964
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No