[Asterisk-code-review] sip to pjsip: Set correct tls transport method (asterisk[14])

Joshua Colp asteriskteam at digium.com
Thu Aug 18 13:44:31 CDT 2016


Joshua Colp has submitted this change and it was merged.

Change subject: sip_to_pjsip: Set correct tls transport method
......................................................................


sip_to_pjsip: Set correct tls transport method

A recent update had a copy/paste error where the unused variable 'val' was
being passed to the set_value function instead of the 'method' value itself.

This patch passes in the right variable.

ASTERISK-22374

Change-Id: I895b7b3779ce4442bc58b8ec40d59dd29bb43f06
---
M contrib/scripts/sip_to_pjsip/sip_to_pjsip.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mark Michelson: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Verified



diff --git a/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py b/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py
index 4a6004a..2134e9a 100755
--- a/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py
+++ b/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py
@@ -797,7 +797,7 @@
         'sslv23' as default when unspecified, which gives TLSv1.0 and v1.2.
         """
         method = 'sslv23'
-    set_value('method', val, 'transport-tls', pjsip, nmapped, 'transport')
+    set_value('method', method, 'transport-tls', pjsip, nmapped, 'transport')
 
     set_transport_common('transport-tls', pjsip, nmapped)
     try:

-- 
To view, visit https://gerrit.asterisk.org/3641
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I895b7b3779ce4442bc58b8ec40d59dd29bb43f06
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list