[Asterisk-code-review] res ari: fix issue reported by zuul (asterisk[13])

Joshua Colp asteriskteam at digium.com
Wed Aug 17 09:58:41 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: res_ari: fix issue reported by zuul
......................................................................


Patch Set 1: Code-Review-1

When making fixes to an existing review you can update that review and not turn it into a series of commits that show your progress. This is done by squashing any subsequent commits into the first one. When you run "git review" again it will update the existing review.

You can also do it all without keeping the original branch so for example for this change:
git review -d 3587 (This downloads the 3587 review and creates a local branch)
<make changes>
git commit -a --amend (This amends the changes to the existing commit)
git review 13 (This puts the new patch set up for review)

It can do this because each commit has a Change-Id which links it to a review.

-- 
To view, visit https://gerrit.asterisk.org/3589
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica56ec84ae99a551bc2db2da0a60c924b675e32f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list