[Asterisk-code-review] sorcery.c: Minor optimizations. (asterisk[14])

Richard Mudgett asteriskteam at digium.com
Mon Aug 15 13:19:22 CDT 2016


Hello Mark Michelson, George Joseph, Anonymous Coward #1000019, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/3496

to look at the new patch set (#2).

Change subject: sorcery.c: Minor optimizations.
......................................................................

sorcery.c: Minor optimizations.

* Remove some unused parameters from internal functions:
sorcery_wizard_create()
sorcery_wizard_update()
sorcery_wizard_delete()

* Created the struct sorcery_observer_invocation ao2 object without a lock
since it is not needed in sorcery_observer_invocation_alloc().

* Cleanup generic ao2 container sorcery object id hash, sort, and cmp
functions.

Change-Id: Iff71d75f52bc1b8cee955456838c149faaa4f92e
---
M main/sorcery.c
1 file changed, 50 insertions(+), 57 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/96/3496/2
-- 
To view, visit https://gerrit.asterisk.org/3496
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff71d75f52bc1b8cee955456838c149faaa4f92e
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list