[Asterisk-code-review] res pjsip session: segfault on already disconnected session (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip_session: segfault on already disconnected session
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.asterisk.org/#/c/3514/3/res/res_pjsip_session.c
File res/res_pjsip_session.c:

Line 216: 	if (session->inv_session && session->inv_session->state == PJSIP_INV_STATE_DISCONNECTED) {
> Should this be !session->inv_session || .... ? If it is possible for the th
The check on inv_session is only to avoid crash if inv_session is null.
I think non-connected if inv_session->state is PJSIP_INV_STATE_NULL.


Line 217: 		ast_log(LOG_ERROR, "Failed to handle incoming SDP. Session has been aready disconnected\n");
> s/aready/already
Done


Line 2886: 		ast_log(LOG_ERROR, "Failed to create session SDP. Session has been aready disconnected\n");
> s/aready/already
Done


-- 
To view, visit https://gerrit.asterisk.org/3514
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d28b1fb3b91f0492a911d110049d670fdc3c8d7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes