[Asterisk-code-review] channels/chan pjsip: Add PJSIP SEND SESSION REFRESH (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: channels/chan_pjsip: Add PJSIP_SEND_SESSION_REFRESH
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3426/2/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

PS2, Line 1026: 	fmt = ast_format_cap_get_best_by_type(ast_channel_nativeformats(session->channel), AST_MEDIA_TYPE_AUDIO);
              : 	if (!fmt) {
              : 		/* No format? That's weird. */
              : 		return 0;
              : 	}
              : 	ast_channel_set_writeformat(session->channel, fmt);
              : 	ast_channel_set_rawwriteformat(session->channel, fmt);
              : 	ast_channel_set_readformat(session->channel, fmt);
              : 	ast_channel_set_rawreadformat(session->channel, fmt);
              : 	ao2_ref(fmt, -1);
Does this actually need to be done or will the normal SDP negotiation (done in res_pjsip_sdp_rtp) as a result of sending the refresh automatically take care of it?


-- 
To view, visit https://gerrit.asterisk.org/3426
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98fe09ba889aafe26d58d32f0fd1323f8fd9b1b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes