[Asterisk-code-review] Produce friendly error when AST MODULE SELF SYM is not defined. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Tue Aug 9 14:13:11 CDT 2016


Corey Farrell has posted comments on this change.

Change subject: Produce friendly error when AST_MODULE_SELF_SYM is not defined.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/3434/2/main/Makefile
File main/Makefile:

Line 287: $(ASTPJ_LIB).$(ASTPJ_SO_VERSION): _ASTCFLAGS+=-fPIC -DAST_MODULE=\"asteriskpj\" -DAST_NOT_MODULE $(PJ_CFLAGS)
> Should this line also be ported to the 13 branch?
AST_NOT_MODULE / AST_MODULE_SELF_SYM didn't exist in 13.


-- 
To view, visit https://gerrit.asterisk.org/3434
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9d35a08104529c516d636771365e02c6e77a45b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list