[Asterisk-code-review] sd notify (systemd status notifications) support (asterisk[master])

[Tzafrir Cohen]

Tzafrir Cohen has posted comments on this change.

Change subject: sd_notify (systemd status notifications) support
......................................................................


Patch Set 2:

> I'd say don't worry about STATUS= for now, that's a separate
 > feature.  I feel like STATUS= should be user definable, a dialplan
 > function would allow AMI/ARI to set.
 > 
 > One possible issue: do we need to unset the SD environment
 > ($NOTIFY_SOCKET) before forking in ast_safe_system?

I suppose that for now, as long as there are no dialplan functions, the ability to play with it from System()/AGI() could help.

-- 
To view, visit https://gerrit.asterisk.org/3094
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied6a59dafd5ef331c5c7ae8f3ccd2dfc94be7811
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-HasComments: No