[Asterisk-code-review] res pjsip mwi: fix unsolicited mwi blocks PJSIP stack (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_mwi: fix unsolicited mwi blocks PJSIP stack
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

Just documentation grammar findings.  Otherwise looks fine to me.

https://gerrit.asterisk.org/#/c/3320/6/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

PS6, Line 959:                     ; Asterisk Task Processor Queue Size
             :                     ; On heavy loaded system with DB storage you may need to increase
             :                     ; taskprocessor queue.
             :                     ; If the taskprocessor queue size reached high water level,
             :                     ; the alert is triggered.
             :                     ; If the alert is set the pjsip distibutor stops processing incoming
             :                     ; requests until the alert is cleared.
             :                     ; The alert is cleared when taskprocessor queue size drops bellow
             :                     ; low water clear level.
             :                     ; The next options set taskprocessor queue levels for MWI.
             : ;mwi_tps_queue_high=500 ; Taskprocessor high water alert trigger level.
             : ;mwi_tps_queue_low=450  ; Taskprocessor low water clear alert level.
             :                     ; The default is 90% of high water level.
Needs similar wording updates as done on the voicemail patch.


Line 978:                     ; on next endpoint's contact update.
s/on next endpoint's contact/on the endpoint's next contact/


https://gerrit.asterisk.org/#/c/3320/6/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 216: 		ast_log(AST_LOG_WARNING, "Invalid the taskprocessor high water alert trigger level '%ld'\n",
s/ the//


Line 223: 		ast_log(AST_LOG_WARNING, "Invalid the taskprocessor low water clear alert level '%ld'\n",
s/ the//


-- 
To view, visit https://gerrit.asterisk.org/3320
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8ecb82c249eb887930980a800c9f87f28f861a
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes