[Asterisk-code-review] app voicemail: Add taskprocessor alert level options. (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: app_voicemail: Add taskprocessor alert level options.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/3318/5/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 14042: 			if (sscanf(val, "%30ld", &tps_queue_low) != 1 || tps_queue_low <= 0 || tps_queue_low >= tps_queue_high) {
> allowing -1, we shouldn't allow -2, -3, etc.
Just noticed your comment on res_pjsip_mwi
"Zero is allowable for the low water mark to clear when the queue is emptied.  low==high is allowable because the alert is triggered when the queue reaches high and cleared when it comes back down to low."
changed to
if (sscanf() != 1 || tps_queue_low < -1 || tps_queue_high < tps_queue_low)


-- 
To view, visit https://gerrit.asterisk.org/3318
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I766294fbffedf64053c0d9ac0bedd3109f043ee8
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes