[Asterisk-code-review] app voicemail: Add taskprocessor alert level options. (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: app_voicemail: Add taskprocessor alert level options.
......................................................................


Patch Set 5:

(5 comments)

https://gerrit.asterisk.org/#/c/3318/5//COMMIT_MSG
Commit Message:

Line 11: It could happen when IMAP or DB server died or not reachable.
> It could happen when the IMAP or DB server dies or is unreachable.
Done


PS5, Line 14: If taskprocessor queue reached high level, the alert is triggered
            : and the pjsip/distributor stops processing new requsts.
> If the taskprocessor queue reaches the high water level then the alert is t
Done


https://gerrit.asterisk.org/#/c/3318/5/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 14042: 			if (sscanf(val, "%30ld", &tps_queue_low) != 1 || tps_queue_low <= 0 || tps_queue_low >= tps_queue_high) {
> Allow -1 to indicate low is 90% of high.
allowing -1, we shouldn't allow -2, -3, etc.
we also shouldn't allow tps_queue_low == tps_queue_high
if (sscanf() != 1 || tps_queue_low == 0 || tps_queue_low < -1 || tps_queue_low >= tps_queue_high)


Line 14048: 			ast_log(AST_LOG_WARNING, "failed to set alert levels for mwi subscription taskprocessor.\n");
> s/failed/Failed/
Done


https://gerrit.asterisk.org/#/c/3318/5/configs/samples/voicemail.conf.sample
File configs/samples/voicemail.conf.sample:

Line 388: 			; The default is 90% of high water level.
> The default is -1 for 90% of high water level.
Done


-- 
To view, visit https://gerrit.asterisk.org/3318
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I766294fbffedf64053c0d9ac0bedd3109f043ee8
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes