[Asterisk-code-review] codecs: Add Codec 2 mode 2400. (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change.

Change subject: codecs: Add Codec 2 mode 2400.
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Other than Josh's comment, I think licensing should be compatible since codec2 appears to be LGPL.

https://gerrit.asterisk.org/#/c/3244/3/main/rtp_engine.c
File main/rtp_engine.c:

Line 2705: 	add_static_payload(126, ast_format_codec2, 0);
We already have a 126 declared below, you'll have to pick something different or pick -1 to dynamically pick (according to Josh Colp)


-- 
To view, visit https://gerrit.asterisk.org/3244
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e45d8084683fab5f2b272bf35f4a149cea8b8d6
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes