[Asterisk-code-review] res pjsip exten state: Create PUBLISH messages. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_exten_state: Create PUBLISH messages.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/2733/1/res/res_pjsip_exten_state.c
File res/res_pjsip_exten_state.c:

PS1, Line 651: 		pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "pub_state_body",
             : 			1024, 1024);
> Instead of creating the memory pool for each iteration you can create it on
Yes, that would be better.


PS1, Line 723: 		&& ast_sip_push_task(publish_exten_state_serializer, exten_state_publisher_cb,
             : 			pub_data)) {
> Why the use of a serializer here?
1) The fact that pjlib is touchy about which thread calls its API's.
2) The fact that pushing the task into a pseudo random thread pool thread would generate the PUBLISH events out of order.


-- 
To view, visit https://gerrit.asterisk.org/2733
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0dab4022f5cf59302129483ed38398764ee3cca
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes