[Asterisk-code-review] res pjsip exten state: Create PUBLISH messages. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Fri Apr 29 10:18:49 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: res_pjsip_exten_state: Create PUBLISH messages.
......................................................................


Patch Set 1:

The implementation can't extend the outbound publish type as it is provided by the outbound publish module itself. That means you either have to use extended variables, or implement some sort of extended variable thing in the outbound publish module itself. Another option would be to refactor that stuff to have an option which specifies the implementation's config to use, and have that passed to the implementation. I opted for the extended variables way originally.

-- 
To view, visit https://gerrit.asterisk.org/2733
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0dab4022f5cf59302129483ed38398764ee3cca
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list