[Asterisk-code-review] sip bye also: Allow an optional 481 to terminate the test g... (testsuite[master])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged.

Change subject: sip_bye_also:  Allow an optional 481 to terminate the test gracefully
......................................................................


sip_bye_also:  Allow an optional 481 to terminate the test gracefully

This test was occasionally failing about 2% of the time because sipp sends
an extra BYE at the end of the test which causes Asterisk to send a 481
which sipp isn't expecting.  I ran the test probably 500 times in various
environments from slow 32 bit to speedy 64 bit and couldn't get it to fail
so the only thing I can think of to make this test more stable is to allow a
481 to end the test gracefully.

ASTERISK-25969 #close

Change-Id: Idffe52f19db296cf5b51bdd25b49f5d855160f33
Reported-by: Joshua Colp
---
M tests/channels/SIP/sip_bye_also/sipp/uac-bye-also.xml
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/tests/channels/SIP/sip_bye_also/sipp/uac-bye-also.xml b/tests/channels/SIP/sip_bye_also/sipp/uac-bye-also.xml
index 2f2ccc2..4bede86 100644
--- a/tests/channels/SIP/sip_bye_also/sipp/uac-bye-also.xml
+++ b/tests/channels/SIP/sip_bye_also/sipp/uac-bye-also.xml
@@ -87,8 +87,13 @@
     ]]>
   </send>
 
+  <recv response="481" optional="true" next="19">
+  </recv>
+
   <recv response="200" crlf="true">
   </recv>
 
+  <label id="19"/>
+
 </scenario>
 

-- 
To view, visit https://gerrit.asterisk.org/2719
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idffe52f19db296cf5b51bdd25b49f5d855160f33
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>