[Asterisk-code-review] translate: Re-enables native Packet-Loss Concealment (PLC) f... (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change.

Change subject: translate: Re-enables native Packet-Loss Concealment (PLC) for iLBC and Speex.
......................................................................


Patch Set 9: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/1820/9/main/translate.c
File main/translate.c:

PS9, Line 548: /* Out-of-order packet - more precise: late packet */
> are we guaranteed (original code seems to indicate that f can be a list of 
Not unless jitter buffering occurs prior to this point - and jitter buffering is enabled.


PS9, Line 597: while (0 < frames_missing) { /* lost packet(s) */
> Can't we insert a single frame with samples = total number of missing sampl
I looked at the codec code involved - unfortunately not.  The PLC interface in codec_speex and codec_ilbc act based on the assumption that a frame lost is a typical codec payload size, versus looking at the number of samples or something like that and deducing that samples/typical-payload-size numbers of frames were lost.


PS9, Line 617: temp = ast_frdup(&missed); /* does not duplicate LIST_NEXT */
> if consume == false these frames will be leaked.
+1


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes