[Asterisk-code-review] app confbridge: Add a regcontext option for confbridge bridg... (asterisk[11])

Jaco Kroon asteriskteam at digium.com
Wed Apr 27 07:48:41 CDT 2016


Jaco Kroon has posted comments on this change.

Change subject: app_confbridge: Add a regcontext option for confbridge bridge profiles.
......................................................................


Patch Set 1:

> (2 comments)
 > 
 > Purely from a coding perspective this is... fine. To get it in
 > you'd need to do it against master, and also update the CHANGES
 > file.

I'm using 11 at the moment, so if it's OK I'd like to finish everything against 11 first, I'll then rebase for master (and 13) if that's acceptable.  I've tested quickly and it does NOT apply clean to master, mostly it's due to cosmetic changes so it shouldn't be too hard.

 > Not really sure how many other people would use it but it's minor
 > enough.

Very few I'd reckon ... not too many people running multi-server installations that I'm aware off, fewer still that requires this level of dynamic flexibility.

-- 
To view, visit https://gerrit.asterisk.org/2708
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icacf94d9f2b5dfd31ef36f6cb702392619a7902f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list