[Asterisk-code-review] res pjsip exten state: Add config support for exten state pu... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_exten_state: Add config support for exten state publishers.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2616/2/res/res_pjsip_exten_state.c
File res/res_pjsip_exten_state.c:

PS2, Line 660: 	body_type = ast_sorcery_object_get_extended(configuration, "body");
             : 	if (ast_strlen_zero(body_type)) {
             : 		ast_log(LOG_ERROR, "Outbound extension state publisher '%s' has no body set\n",
             : 			ast_sorcery_object_get_id(configuration));
             : 		return -1;
             : 	}
             : 	body_type_size = strlen(body_type) + 1;
This should break the body into the type and subtype strings to get stuffed as separate strings into the publisher struct.  This also appears to be the only validation for the @body string.

@body=application/pidf+xml

body_type = application
body_subtype = pidf+xml


-- 
To view, visit https://gerrit.asterisk.org/2616
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7e630136dfc355073c1cadff8ad394a08523d78
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes