[Asterisk-code-review] config: Fix ast config text file save2 writability check fo... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Mon Apr 25 18:05:58 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: config:  Fix ast_config_text_file_save2 writability check for missing files
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2691/3/main/config.c
File main/config.c:

Line 2523: 		if (!dn || access(dn, R_OK | W_OK)) {
!dn check not needed ast_strdupa() can never fail.


-- 
To view, visit https://gerrit.asterisk.org/2691
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4dbe58c277a47b674679e49daed5fc6de349f80
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jonathan R. Rose <jonathan.rose at motorolasolutions.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list