[Asterisk-code-review] chan sip: Ensure TCP/TLS threads are terminated before unloa... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: chan_sip: Ensure TCP/TLS threads are terminated before unloading.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2701/1/channels/chan_sip.c
File channels/chan_sip.c:

PS1, Line 35275: 	/* Wait for the existing TCP/TLS threads to stop */
               : 	while (ao2_container_count(threadt)) {
               : 		usleep(1);
               : 	}
Look at the use of wait_count below.  This loop is implemented there but allowed to loop only so many times before giving up.  Should change that loop to wait a set number of seconds instead of number of loops executed.


-- 
To view, visit https://gerrit.asterisk.org/2701
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc6262b670ca49ede32061159e323b7b63c6f3c6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes