[Asterisk-code-review] Manager: Short circuit AMI message processing. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: Manager: Short circuit AMI message processing.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/2593/2/main/stasis_message.c
File main/stasis_message.c:

PS2, Line 173: #define INVOKE_VIRTUAL(fn, ...)					\
             : 	({											\
             : 		if (!msg) {								\
             : 			return NULL;						\
             : 		}										\
             : 		ast_assert(msg->type != NULL);			\
             : 		ast_assert(msg->type->vtable != NULL);	\
             : 		if (!msg->type->vtable->fn) {			\
             : 			return NULL;						\
             : 		}										\
             : 		msg->type->vtable->fn(__VA_ARGS__);		\
             : 	})
I'm guessing that you use a 4-space tab and the original author of this macro used an 8-space tab. It looks like your changes are mangling the formatting of these backslashes.

If we really want the backslashes aligned, then spaces are the way to go here.

Same goes for your new HAS_VIRTUAL macro below.


-- 
To view, visit https://gerrit.asterisk.org/2593
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b22fc5ec4e500d00635c1a467aa8ea68a1bb2b3
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes