[Asterisk-code-review] config: Fix ast config text file save writability check for... (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: config:  Fix ast_config_text_file_save writability check for missing files
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2693/2/include/asterisk/utils.h
File include/asterisk/utils.h:

Line 734:  * This is a portable version of 'basename(3)'.
s/basename/dirname/


https://gerrit.asterisk.org/#/c/2693/2/main/utils.c
File main/utils.c:

Line 2237: char *ast_dirname(const char *path)
This doesn't deal with the "/file" case nor does it deal with the "/usr/" case.


-- 
To view, visit https://gerrit.asterisk.org/2693
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4dbe58c277a47b674679e49daed5fc6de349f80
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jonathan R. Rose <jonathan.rose at motorolasolutions.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes