[Asterisk-code-review] app queue: queue members can receive multiple calls (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_queue: queue members can receive multiple calls
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/2679/1/apps/app_queue.c
File apps/app_queue.c:

Line 3695: 		struct member *member;
I'd appreciate it if you would use mem as the variable name like most other places in the code.


Line 3719: 		if (member_call_pending_set(call->member)) {
Actually the member_call_pending_set() and member_call_pending_clear() functions were created to fix a similar issue within a queue so the associated code can be removed because this patch works globally as well as within a queue.

Remove:
member_call_pending_set()
member_call_pending_clear()
struct member.call_pending


-- 
To view, visit https://gerrit.asterisk.org/2679
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice45a1c95b9f6f15d8a9fa709c5e5c84ffd29780
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes