[Asterisk-code-review] app queue: queue members can receive multiple calls (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_queue: queue members can receive multiple calls
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/2679/1/apps/app_queue.c
File apps/app_queue.c:

Line 1702: 	return strcmp(object_left->interface, right_key) ? 0 : CMP_MATCH | CMP_STOP;
CMP_STOP is rarely ever needed and in this case it prevents the use of OBJ_MULTIPLE from finding more than one.  If you are looking for one object we automatically stop when we find one.  This is only needed when you need to abort a search before you find the object or you want to stop an OBJ_MULTIPLE search early.


Line 3789: 		member_call_pending_clear(tmp->member);
Need to remove the member from the pending container.
call failed


Line 3871: 		member_call_pending_clear(tmp->member);
Need to remove the member from the pending container.
call failed


-- 
To view, visit https://gerrit.asterisk.org/2679
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice45a1c95b9f6f15d8a9fa709c5e5c84ffd29780
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes