[Asterisk-code-review] app queue: queue members can receive multiple calls (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: app_queue: queue members can receive multiple calls
......................................................................


Patch Set 1:

> you might want to make the container a RWLOCK

Thought about this some and I think this scenario needs the mutex lock. If I use a read lock to search and it is not found then I have to release that lock and then obtain a write lock. It's possible that between the release of the read and getting the write that another thread could try to find the object. It too won't be found and then we'll end up with two of the same member objects added to the container and the member's phone being rung by both threads.

-- 
To view, visit https://gerrit.asterisk.org/2677
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I546dd474776d158c2b6be44205353dee5bac7e48
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No